ping @lcdservices

@monishdeb this isn't right. The distinguishing factor is not whether they share an address, but whether a household relationship exists.

• Indiv A and Indiv B have the same address and are joined to Household C
• Currently, merge same address results in A+B exported as a single record and C also exported
• What should happen is that only Household C be exported

Merge same address gives preference to the existence of a household relationship. It is intended as an extension of the "merge household" function -- it looks for contacts not connected by a household and merges them AND also merges via household.

I think the confusion is with the help text:

Merge Contacts with the Same Address will combine any records having the same address (street address, city, postal code, country) into a single record. If a household record already exists in which multiple individuals share an address, the household will be exported as the combined record. If no household record exists, the records will be combined and the Addressee field will list the contact names, comma-separated.

The phrase "in which multiple individuals share an address" was not intended to be interpreted as referring to the share address functionality. It was intended to mean, if two individuals have the same address and have a household relationship, the household record will be exported.

To put it another way -- the goal of these two tools is to allow orgs to collapse records down and reduce mailing costs. Merge household does that strictly -- there must be a household relationship present. Merge address does it more dynamically (extends the functionality) -- if a household record exists, we use that; but if it doesn't, we try to collapse/merge them down based on matching addresses.

this would need a test

@eileenmcnaughton @lcdservices I have updated the PR which is dependent on #11870 changes. The reason why I have to cherrpick the commit from previous, and do the change on the top of it. Also updated the description and added UT. Please have look :)

@monishdeb ran some tests and this looks good -- contacts are now merged into households if those relationships exist.

jenkins test this please

@monishdeb I'm going to close this one out until we have resolved #11870

I can't see myself being able to review either of them until we have gotten the code to a state of legibility so I feel these 2 have to be 'longer term projects'

(as an aside - the trick to re-opening as opposed to creating new is to reopen before you force-push)